Advanced date override handling and timezone compatibility improvements #5
Conversation
* fix date override for fixed round robin + time zone in date override * check if slot is within working hours of fixed hosts * add test for date override in different time zone * fix date overrides for not fixed hosts (round robin) * code clean up * fix added test * use the correct timezone of user for date overrides --------- Co-authored-by: CarinaWolli <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // slot is not within the date override | ||
| return false; | ||
| } | ||
|
|
||
| if (dateOverrideExist) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
When checkIfIsAvailable sees a date override for the given day, it now returns true immediately (lines 133‑134) once the slot is confirmed to lie within that override. This short‑circuits the function before the busy calendar/bookings logic that follows, so any busy entries and seat limits are ignored whenever a date override exists. As a result, any slot inside a date override is marked available even if the organizer already has an overlapping booking or connected-calendar conflict, which can lead directly to double-booking. The function should continue to the busy/seat checks after confirming the slot is inside the override instead of returning early.
Useful? React with 👍 / 👎.
Test 7
Replicated from ai-code-review-evaluation/cal.com-cursor#7